Re-review of bare metal chapter #42
Conversation
| . `tfm-rubygem-foreman_discovery` | ||
| endif::[] | ||
| . `foreman-discovery-image` | ||
| . `rubygem-smart_proxy_discovery` |
There was a problem hiding this comment.
Not sure if . means a bullet, need to check.
There was a problem hiding this comment.
It means number, ordered list, so change to * for foreman ifeval because you can't have a list of 1
There was a problem hiding this comment.
Note tfm- is a EL7 thing. Once we'll support EL8, it will change. For manual installs you can also use foreman-plugin-discovery which should be provided by the correct package. Similar we also have foreman-proxy-plugin-discovery instead of rubygem-smart_proxy_discovery (which will change to tfm-rubygem-smart_proxy_discovery in Foreman 1.24). Please do test this before putting in a manual though :)
| ifeval::["{build}" == "satellite"] | ||
| [NOTE] | ||
| Discovery `kexec` is a Technology Preview feature. | ||
| endif::[] |
There was a problem hiding this comment.
Indeed it is, it's a painful one and we are getting rid of it. We need to be very explicit to maybe stop users from using it before they get into trouble.
There was a problem hiding this comment.
There are more docs on this that I am weeding out of another guide and trying to put in here. I keep getting distracted from it. Maybe we can look at it together on one of our calls.
There was a problem hiding this comment.
It's going away anyway in a year or something. I would not be worried too much.
| ifeval::["{build}" == "satellite"] | ||
| [NOTE] | ||
| Discovery `kexec` is a Technology Preview feature. | ||
| endif::[] |
There was a problem hiding this comment.
There are more docs on this that I am weeding out of another guide and trying to put in here. I keep getting distracted from it. Maybe we can look at it together on one of our calls.
|
I found another thing: Please search the file for this repo --name=rhel --baseurl=http://download/released/RHEL-7/7.4/Server/x86_64/os/ What should we do with this link, or is it OK? |
|
Commas and articles are the thing for me. I am wondering, if you spot some common mistakes can you start tracking them and then put them into the README. I can see that "Click OK to save" is a pattern I need to learn and a good candidate. |
I think it's ok. It's in the file anyway and it's generic "download" hostname which is probably safe. |
lzap
force-pushed
the
bare-metal-rereview
branch
from
79f7d62
to
65856ca
Compare
|
Added new commit. |
* Re-review of bare metal chapter * grammar/style updates * Incorporated some comments * Removed unwanted changes
A lot of changes, most of them are actually not related to upstreamize process.