New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bz#1796445 #86
Merged
Merged
Bz#1796445 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445
As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445
As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445
As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445
As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445
As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445
tahliar
reviewed
Feb 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks sensible. Caught a few sneaky ones:
guides/common/modules/con_ports-and-firewalls-requirements.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/downloading_installing_satellite_disconnected.adoc
Show resolved
Hide resolved
guides/common/modules/tuning-satellite-server-with-predefined-profiles.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/tuning-satellite-server-with-predefined-profiles.adoc
Outdated
Show resolved
Hide resolved
guides/doc-Installing_Satellite_Server_Disconnected/master.adoc
Outdated
Show resolved
Hide resolved
As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445
Hi @trichard10 please review again. All your points are valid but some will be dealt with as part of the main upstreaming work. This is just the initial foundation. Real work begins once this PR is merged :D |
ianf77
pushed a commit
to ianf77/foreman-documentation
that referenced
this pull request
Feb 14, 2022
* upstreamized guides As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445 * Upstreamize master.adoc files ProductName attribute As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445 * Add satellite-maintain attribute As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445 * s/satellite-installer/foreman-installer As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445 * s/satellite.example.com/{foreman.example.com} As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445 * correct the foreman.example.com attribute As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445 * Add @trichard10's feedback As part of Bug 1796445 - Run the upstreamize.rb script on the installation guides https://bugzilla.redhat.com/show_bug.cgi?id=1796445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the upstreamize script on installation guides
As part of
Bug 1796445 - Run the upstreamize.rb script on the installation guides
https://bugzilla.redhat.com/show_bug.cgi?id=1796445