Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bz#1796445 #86

Merged
merged 7 commits into from Feb 4, 2020
Merged

Bz#1796445 #86

merged 7 commits into from Feb 4, 2020

Conversation

melcorr
Copy link
Member

@melcorr melcorr commented Jan 30, 2020

Run the upstreamize script on installation guides

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445

Melanie Corr added 2 commits January 30, 2020 13:51
As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445
As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445
@melcorr melcorr requested a review from spetrosi January 30, 2020 14:45
Melanie Corr added 2 commits January 31, 2020 14:07
As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445
As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445
Melanie Corr added 2 commits January 31, 2020 15:08
As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445
As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445
@melcorr melcorr requested review from tahliar and removed request for spetrosi February 3, 2020 08:42
Copy link
Contributor

@tahliar tahliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks sensible. Caught a few sneaky ones:

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445
@melcorr
Copy link
Member Author

melcorr commented Feb 3, 2020

Hi @trichard10 please review again. All your points are valid but some will be dealt with as part of the main upstreaming work. This is just the initial foundation. Real work begins once this PR is merged :D

@tahliar tahliar merged commit 8e28518 into theforeman:master Feb 4, 2020
ianf77 pushed a commit to ianf77/foreman-documentation that referenced this pull request Feb 14, 2022
* upstreamized guides

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445

* Upstreamize master.adoc files ProductName attribute

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445

* Add satellite-maintain attribute

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445

* s/satellite-installer/foreman-installer

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445

* s/satellite.example.com/{foreman.example.com}

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445

* correct the foreman.example.com attribute

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445

* Add @trichard10's feedback

As part of

Bug 1796445 - Run the upstreamize.rb script on the installation guides

https://bugzilla.redhat.com/show_bug.cgi?id=1796445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants