Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom facts #42

Merged
merged 1 commit into from Oct 24, 2016
Merged

Add custom facts #42

merged 1 commit into from Oct 24, 2016

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Oct 23, 2016

This uses the rspec-puppet-facts 1.7 feature to add custom facts. Since
we often override this in our specs this can greatly reduce duplication
in our specs.

This uses the rspec-puppet-facts 1.7 feature to add custom facts. Since
we often override this in our specs this can greatly reduce duplication
in our specs.
@ekohl
Copy link
Member Author

ekohl commented Oct 23, 2016

Accidentally pushed the sync to master:

@ekohl
Copy link
Member Author

ekohl commented Oct 23, 2016

@ekohl
Copy link
Member Author

ekohl commented Oct 23, 2016

puppet-tftp still fails, puppetlabs/puppetlabs-xinetd#81 is still open to fix it.

@mmoll mmoll merged commit 1338a46 into theforeman:master Oct 24, 2016
@mmoll
Copy link
Contributor

mmoll commented Oct 24, 2016

As all the builds went OK, there's no reason not to merge this to the sync source, bedankt @ekohl!

@ekohl ekohl deleted the add-custom-facts branch October 24, 2016 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants