This repository has been archived by the owner on May 26, 2020. It is now read-only.
Install provisioning template that configures bonds #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waiting on theforeman/foreman#1782 |
| <% next if !interface.managed? || interface.subnet.nil? -%> | ||
| <% next if bonded_interfaces.include?(interface.identifier) -%> |
There was a problem hiding this comment.
(Disclaimer: i'm a networking newbie so it's possible that my question is dumb.)
I see that this will exclude all the bond.attached_devices_identifiers for each bond, but will this also exclude the bond itself (the bonding master)? I don't see that being added to bonded_interfaces. Or is it that @host.bond_interfaces never appear in @host.managed_interfaces?
There was a problem hiding this comment.
@host.managed_interfaces uses Host#managed scope which does the following
scope :managed, lambda { where(:type => "Nic::Managed") }
bond interfaces have "Nic::Bond" type so they are never listed there
|
ACK. Merging. |
bcrochet
added a commit
that referenced
this pull request
Oct 8, 2014
Install provisioning template that configures bonds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.