Fixes #34888: Display katello-certs-check output only if error

theforeman · May 10, 2022 · 688d0a7 · 688d0a7
1 parent f5b9904
commit 688d0a7
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/hooks/pre_commit/20-certs_update.rb b/hooks/pre_commit/20-certs_update.rb
@@ -14,6 +14,10 @@
   key_file  = param('certs', 'server_key').value
 
   unless app_value(:certs_skip_check) || [cert_file, ca_file, key_file].all? { |v| v.to_s.empty? }
-    execute!(%(katello-certs-check -c "#{cert_file}" -k "#{key_file}" -b "#{ca_file}"))
+    stdout_stderr, success = execute_command(%(katello-certs-check -c "#{cert_file}" -k "#{key_file}" -b "#{ca_file}"), false, true)
+
+    unless success
+      log_and_say(:error, stdout_stderr, true, false)
+    end
   end
 end