Add foreman_azure to config #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also add a new config file migration, see ff04cd1 for an example. |
dLobatog
force-pushed
the
installer-azure
branch
from
405e36b
to
2909b2d
Compare
| @@ -0,0 +1,2 @@ | |||
| +answers['foreman::plugin::azure'] ||= false | |||
There was a problem hiding this comment.
There's a leading + on these lines causing the migration (and tests) to fail.
dLobatog
force-pushed
the
installer-azure
branch
from
2909b2d
to
e81dce1
Compare
theforeman-bot
added
Needs testing
Needs re-review
and removed
Waiting on contributor
labels
|
Updated to fix the typo on the migration |
|
Merged, thanks @dLobatog! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on theforeman/puppet-foreman#456