Pin postgres and concat #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoll
suggested changes
Jun 26, 2017
Puppetfile
Outdated
| @@ -2,7 +2,8 @@ forge 'https://forgeapi.puppetlabs.com' | |||
|
|
|||
| # Dependencies | |||
| mod 'puppetlabs/mysql', '>= 3.8.0' | |||
| mod 'puppetlabs/postgresql', '>= 4.8.0' | |||
| mod 'puppetlabs/postgresql', '< 5.0.0' | |||
There was a problem hiding this comment.
mod 'puppetlabs/postgresql', '>= 4.8.0', '< 5.0.0' would be more correct
ehelms
force-pushed
the
pin-potsgres-concat
branch
from
f1bd415
to
a87a6f1
Compare
Should be unpinned once puppetlabs/puppetdb dependency on postgres is updated.
ehelms
force-pushed
the
pin-potsgres-concat
branch
from
a87a6f1
to
d44302f
Compare
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
@mmoll Good call -- updated |
mmoll
approved these changes
Jun 26, 2017
|
merged, thanks @ehelms! |
|
When puppetlabs/puppetlabs-puppetdb#260 is merged and released I think we can remove the pinning again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be unpinned once puppetlabs/puppetdb dependency on postgres
is updated.