Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #27847 - Set parameter mapping #397

Merged
merged 1 commit into from Sep 24, 2019

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 23, 2019

In puppet-certs master the default values are loaded via params.pp to workaround kafo limitations. This configures kafo to actually find it. Otherwise it can't load the defaults and the values are nil.

In puppet-certs master the default values are loaded via params.pp to
workaround kafo limitations. This configures kafo to actually find it.
Otherwise it can't load the defaults and the values are nil.
@ekohl
Copy link
Member Author

ekohl commented Sep 24, 2019

It can't generate the defaults but not sure why.

$ bundle exec $INSTDIR/sbin/foreman-proxy-certs-generate --help

Could not get default values, check log file at /tmp/tmp.oueXiC0vj1/var/log/foreman-installer/foreman-proxy-certs-generate.log for more information

The command "bundle exec $INSTDIR/sbin/foreman-proxy-certs-generate --help" exited with 25.

10.67s$ bundle exec $INSTDIR/sbin/foreman-proxy-certs-generate --help |grep -q certs-update-server

The command "bundle exec $INSTDIR/sbin/foreman-proxy-certs-generate --help |grep -q certs-update-server" exited with 1.

@ekohl
Copy link
Member Author

ekohl commented Sep 24, 2019

Error: Evaluation Error: Operator '[]' is not applicable to an Undef Value. (file: /tmp/tmp.sAudVOhpMm/share/foreman-installer/modules/certs/manifests/foreman_proxy_content/params.pp, line: 9, column: 18)

The problem is $facts['networking']['fqdn'] which is the modern fact, but that requires facter 3. In bundler we can only have facter 2 which means $facts['networking'] is undef. undef['fqdn'] doesn't work.

@ekohl
Copy link
Member Author

ekohl commented Sep 24, 2019

💚 due to theforeman/puppet-certs#260 being merged.

@ekohl ekohl merged commit 425987e into theforeman:develop Sep 24, 2019
@ekohl ekohl deleted the 27847-params-mapping branch September 24, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants