Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #28353 - Move fail_and_exit to HookContextExtension #424

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Refs #28353 - Move fail_and_exit to HookContextExtension #424

merged 1 commit into from
Dec 5, 2019

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 5, 2019

By placing it in HookContextExtension, it can be used in every hook without redefining it.

@ekohl
Refs #28353 - Move fail_and_exit to HookContextExtension
ff1a60b 
By placing it in HookContextExtension, it can be used in every hook
without redefining it.
evgeni
evgeni approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like red diffs

@ekohl
Copy link
Member Author

ekohl commented Dec 5, 2019

I like red diffs

Unlike test results, here red is good :)

@evgeni evgeni merged commit 0655b5c into theforeman:develop Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
3 participants
@ekohl @evgeni @theforeman-bot