Refs #28353: Drop Kafo::Helpers and move to extensions #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Dec 12, 2019
| end | ||
|
|
||
| def log_and_say(level, message, do_say = true, do_log = true) | ||
| style = case level |
There was a problem hiding this comment.
I was thinking about this and if we can actually add them to the color scheme that Kafo already uses.
There was a problem hiding this comment.
Sounds like a good one to capture into a Redmine issue.
|
|
||
| # \ and ' characters could cause trouble in ERB, make sure to escape them | ||
| escaped_message = message.gsub('\\', '\\\\\\').gsub("'", %q{\\\'}) | ||
| say "<%= color('#{escaped_message}', :#{style}) %>" if do_say |
There was a problem hiding this comment.
I was looking at this but haven't tried yet if it works:
Suggested change
| say "<%= color('#{escaped_message}', :#{style}) %>" if do_say | |
| say HighLine.color(message, style.to_sym) if do_say |
|
For moving into Kafo -- https://projects.theforeman.org/issues/28498 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.