Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #28353: Rename boot hooks to option naming convention #431

Closed
wants to merge 1 commit into from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Dec 12, 2019

No description provided.

@ekohl
Copy link
Member

ekohl commented Dec 12, 2019

I think the Ruby convention is underscores. Since they're ruby files, should we instead adopt that?

@ehelms
Copy link
Member Author

ehelms commented Dec 12, 2019

I suppose I can go either way. There are guidelines, but less clear for this:

https://guides.rubygems.org/name-your-gem/

So reading that I suppose sticking with:

--name_of_the_thing.rb

e.g.

10-option-reset.rb
11-option-clear_pulp_content.rb

@ehelms
Copy link
Member Author

ehelms commented Dec 16, 2019

@ekohl thoughts on the naming?

@ehelms ehelms closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants