Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #28839 - Reset pulpcore db with reset #459

Merged
merged 1 commit into from Feb 25, 2020
Merged

Fixes #28839 - Reset pulpcore db with reset #459

merged 1 commit into from Feb 25, 2020

Conversation

sjha4
Copy link
Contributor

@sjha4 sjha4 commented Jan 29, 2020 •
edited

To test:

  1. Spin up a nightly.
  2. Run foreman-installer --foreman-proxy-plugin-pulp-pulpcore-enabled=true on the nightly box to enable pulpcore.
  3. Pull in these changes. I did these changes directly on the installed foreman-installer files on the nightly under /usr/share/foreman-installer
  4. Run foreman-installer --reset

You will need to be on the latest foreman-maintain.

@ekohl
Copy link
Member

ekohl commented Feb 12, 2020

There is now a merge conflict as well.

@sjha4
Copy link
Contributor Author

sjha4 commented Feb 24, 2020

This should be ready now..nighlty spins up with staging repos and the remote db changes are in. Updated the PR with the remote pulpcore db changes addressed.

ekohl
ekohl approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, but the code looks correct.

@ehelms ehelms merged commit b9eb217 into theforeman:develop Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjeffers jjeffers jjeffers left review comments

@ekohl ekohl ekohl approved these changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
Needs testing
Projects
None yet
Milestone
No milestone
5 participants
@sjha4 @ekohl @jjeffers @ehelms @theforeman-bot