Refs #28903 - Swap the postgresql{,-server} removal #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should not I haven't tested this before, just wanted to share this before I headed out. |
|
Doesn't work :/ Puppet keeps ordering them itself so they need to be split up. |
|
Pushed an updated version that I'm now testing. |
ehelms
reviewed
Mar 6, 2020
| failure_message = "Failed to ensure rh-postgresql12-syspaths is the system PostgreSQL" | ||
|
|
||
| logger.info("Ensuring rh-postgresql12-syspaths is the system PostgreSQL") | ||
| apply_puppet_code(puppet_code, failure_message) |
There was a problem hiding this comment.
I get the concept and power of this code, the interface as a developer is just now much uglier :/ This is also a larger re-factoring of the change compared to:
ensure_packages(['postgresql-server'], 'absent')
ensure_packages(['postgresql'], 'absent')
I'll be curious to see how testing goes, but my vote is still the above.
There was a problem hiding this comment.
I considered the same. Given it needs to be cherry picked, I'm tempted to agree with you.
postgresql can't be removed until postgresql-server is removed. 72d7c3f caused the order to be swapped. This ensures a correct order.
|
Ready to review now. |
ehelms
approved these changes
Mar 6, 2020
|
2.0 - f08b784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgresql can't be removed until postgresql-server is removed. 72d7c3f swapped the order. This swaps the order around.