Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #33046: Move scenarios to /var/lib/foreman-installer #698

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Jul 17, 2021

This change moves scenarios from system config directory to the
shared state directory in /var/lib. The answers and config files
act as databases recording the current state of a scenario and
are not intended to be directly edited. Direct changes to the answers
file or configuration file can lead to inconsistencies or improper
values are that intended to be caught by validation. Moving to
the shared state directory draws this line better and emphasizes to
users that they should not be touching these files directly.

I wanted to see how much work this would be, and the impact and whether it was small enough to warrant consideration for Foreman 3.0 changes. I am however, completely OK with this being picked up for 3.1.

Projects that need checking:

This change moves scenarios from system config directory to the
shared state directory in /var/lib. The answers and config files
act as databases recording the current state of a scenario and
are not intended to be directly edited. Direct changes to the answers
file or configuration file can lead to inconsistencies or improper
values are that intended to be caught by validation. Moving to
the shared state directory draws this line better and emphasizes to
users that they should not be touching these files directly.
@ekohl
Copy link
Member

ekohl commented Jul 22, 2021

I wanted to see how much work this would be, and the impact and whether it was small enough to warrant consideration for Foreman 3.0 changes. I am however, completely OK with this being picked up for 3.1.

While I'd like it to be in 3.0, I think given the time and other priorities it's more of a 3.1 thing.

Projects that need checking:

I think there's also other tools in foreman-packaging.git. At least katello-change-hostname is one (though I think I fixed that by reading the scenario file).

@ekohl
Copy link
Member

ekohl commented Jul 6, 2022

For now I'm moving this back to a draft status, while I'd still love to see it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants