Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots are failing #130

Closed
1 of 5 tasks
Ron-Lavi opened this issue Mar 22, 2020 · 2 comments
Closed
1 of 5 tasks

Snapshots are failing #130

Ron-Lavi opened this issue Mar 22, 2020 · 2 comments

Comments

@Ron-Lavi
Copy link
Member

I'm submitting a…

  • Regression (a behavior that used to work and stopped working in a new release)
  • Bug report
  • Feature request
  • Documentation issue or request
  • Support request

Expected Behavior

Snapshots should pass

Current Behavior

Snapshots are failing after one of the latest libraries upgrade

Possible Solution

find the library that caused it and pin to the last version

Steps to Reproduce (for bugs)

run tests, or see latest travis runs, e.g: https://travis-ci.org/github/theforeman/foreman/jobs/665423667

Environment

  • @theforeman/test@4.2.1
  • foreman-js version: 4.2.1
  • Node version: v12.14.1
  • NPM version: 6.13.4
  • Operating system: Linux
@sharvit
Copy link
Contributor

sharvit commented Mar 23, 2020

Thanks for reporting @LaViro 👍

I don't see any snapshot failures in your Travis job but I do see it failed about publishing coverage.

@Ron-Lavi
Copy link
Member Author

Seems like a caching issue.. solved on yesterday evening by itself, closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants