feat(vendor-core): add @reduxjs/toolkit library #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrisker
requested changes
Jul 12, 2021
There was a problem hiding this comment.
You'll also need to expose it in https://github.com/theforeman/foreman-js/blob/master/packages/vendor-core/lib/modules.js
The PR processor doesn't understand this format, you'll need to manually link this to the redmine issue and close it once its merged. |
part of the RFC in https://community.theforeman.org/t/rethinking-react-redux-folder-structure/24183 ISSUES: Fixes #32903
Ron-Lavi
force-pushed
the
add_redux_toolkit
branch
from
bffae61
to
8d52d56
Compare
Thanks, added.
will do. 👍🏼 |
tbrisker
approved these changes
Jul 13, 2021
|
🎉 This PR is included in version The release is available on:
Thank you for your contribution, your foreman-js bot 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of the RFC in https://community.theforeman.org/t/rethinking-react-redux-folder-structure/24183
ISSUES: Fixes #32903