Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(builder): bump babel/preset-env #471

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Dec 14, 2023

Had to add @babel/plugin-proposal-optional-chaining as it was not being install as part of babel/preset-env anymore

@MariaAga MariaAga marked this pull request as ready for review December 14, 2023 10:51
@jeremylenz
Copy link
Contributor

Doesn't JS come standard with optional chaining nowadays? Is the babel one still needed?

@MariaAga
Copy link
Member Author

@jeremylenz foreman tests were failing because it was missing

Copy link
Contributor

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then. LGTM 👍

@jeremylenz jeremylenz merged commit 0e228ce into theforeman:master Dec 14, 2023
14 checks passed
Copy link

MariaAga added a commit to MariaAga/foreman-js that referenced this pull request Dec 20, 2023
MariaAga added a commit to MariaAga/foreman-js that referenced this pull request Dec 20, 2023
MariaAga added a commit to MariaAga/foreman-js that referenced this pull request Dec 20, 2023
MariaAga added a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants