Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): syntax error in presets catch #75

Merged
merged 1 commit into from Dec 2, 2019
Merged

fix(builder): syntax error in presets catch #75

merged 1 commit into from Dec 2, 2019

Conversation

sharvit
Copy link
Contributor

@sharvit sharvit commented Dec 2, 2019

Updated Packages

  • root
  • @theforeman/builder
  • @theforeman/env
  • @theforeman/vendor
  • @theforeman/vendor-dev
  • @theforeman/vendor-core

PR Type

  • Bugfix
  • Feature
  • Code style update (whitespace, formatting, missing semicolons, etc.)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other… Please describe:

Description

Attempt to fix the build error here:
https://ci.theforeman.org/job/test_develop_pr_core/2881/database=postgresql-integrations,ruby=2.5,slave=fast/console
theforeman/foreman#7178

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR fixes open issues?

  • Yes
  • No

Do you use this PR in another repository?

@sharvit sharvit merged commit 44a50a2 into theforeman:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sharvit