Various CI fixes adding new Ansible versions and from FAM repository #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Ansible changes look good, no idea why Molecule is failing in the installer tho |
evgeni
reviewed
Dec 2, 2021
.github/workflows/main.yml
Outdated
| - name: Install Ansible | ||
| run: pip install --upgrade git+https://github.com/ansible/ansible.git@${{ matrix.ansible }} | ||
| run: pip install --upgrade -r ansible |
There was a problem hiding this comment.
this looks wrong. -r means requirements file, but ansible is none.
and without -r this would install some ansible, not the one we want in this matrix
|
the ansible team is currently trying to fix the 5.0.0 problem that 5.0.0 is confusing installations on py 2.7 and 3.5, see ansible-community/community-topics#54 |
|
The molecule failure is due to theforeman/puppet-foreman#1009 |
evgeni
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was gonna break these out trying to parser changes from FAM but lumped it together, lets see if it fixes CI @evgeni