Fixes #23134 - support for plugin hooks #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
approved these changes
May 29, 2018
|
You want me to workaround it? I'd be very surprised there was a libexec executable with space, this is not MacOS :-) |
|
Working around it should be quite easy and I'd rather stay on the safe side, just to be sure. |
|
Ok done. |
adamruzicka
reviewed
May 30, 2018
foreman-proxy-selinux-relabel
Outdated
| @@ -8,4 +15,9 @@ | |||
| /var/log/foreman-proxy \ | |||
| /var/run/foreman-proxy | |||
|
|
|||
| # Run hooks | |||
| for HOOK in "$LIBEXEC_DIR/*-after-relabel.sh"; do | |||
There was a problem hiding this comment.
The escaping needs to be done in a slightly different way, see here
There was a problem hiding this comment.
Hmmm good catch, I have tested this incorrectly.
|
I actually could not get your example work, but found different solution via find, no shell involved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to allow to katello-selinux to hook onto foreman-selinux-enable (disable, relabel) scripts easily.
This can be done via /usr/libexec/foreman-selinux/enable.d/*.after.sh (and before.sh) scripts executed before or after scripts.
Packaging PR will follow once this is merged to get that directory created.