Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #10741 - Support for smart_proxy_dynflow #125

Merged
merged 4 commits into from Aug 13, 2015
Merged

Refs #10741 - Support for smart_proxy_dynflow #125

merged 4 commits into from Aug 13, 2015

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Jul 16, 2015

Ability to trigger action on foreman server and a corresponding action in
smart proxy, get the callback at the end and dispatch the control events (such
as cancel)

Depends on theforeman/smart_proxy_dynflow#1

@iNecas iNecas mentioned this pull request Jul 16, 2015
Merged
1 task
@iNecas
Refs #10741 - Support for smart_proxy_dynflow
8822505 
Ability to trigger action on foreman server and a corresponding action in smart
proxy, get the callback at the end and dispatch the control events (such as
cancel)
@iNecas
Copy link
Member Author

iNecas commented Aug 11, 2015

[test]

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • f18b59b must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member Author

iNecas commented Aug 11, 2015

I've rebased and fixed tasks reloading for planned tasks

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • f18b59b must be in the format Fixes/refs #redmine_number - brief description.
  • 1b0a9c0 must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • f18b59b must be in the format Fixes/refs #redmine_number - brief description.
  • 96eb7b5 must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • f18b59b must be in the format Fixes/refs #redmine_number - brief description.
  • c30d42e must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member Author

iNecas commented Aug 13, 2015

Due to cancelling enhancements, it requires Dynflow/dynflow#162

ares
ares reviewed Aug 13, 2015
View reviewed changes
lib/foreman_tasks/test_extensions.rb
def setup
super
if defined?(AccessPermissionsTest) && self.class == AccessPermissionsTest
skip if __name__.include?('foreman_tasks/api/tasks/callback')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to add justifying comment here

@ares
Copy link
Member

ares commented Aug 13, 2015

ACK, comment is optional :-)

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 8984321 must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member Author

iNecas commented Aug 13, 2015

The jenkins seemed to get stuck on some platforms, but majority of them worked: I don't see anything related ot this code: merging so that we can move forward with theforeman/foreman_remote_execution#11

iNecas added a commit that referenced this pull request Aug 13, 2015
@iNecas
Merge pull request #125 from iNecas/proxy-dynflow
fd2206a 
Refs #10741 - Support for smart_proxy_dynflow
@iNecas iNecas merged commit fd2206a into theforeman:master Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
3 participants
@iNecas @theforeman-bot @ares