Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #10753 - Support for setting future time of execution #131

Merged
merged 2 commits into from Sep 17, 2015
Merged

Refs #10753 - Support for setting future time of execution #131

merged 2 commits into from Sep 17, 2015

Conversation

adamruzicka
Copy link
Contributor

Support for setting future time of execution and displaying info about delayed tasks

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 7ed1cd2 must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@adamruzicka
Copy link
Contributor Author

Commit 7ed1cd2 requires Dynflow/dynflow#167

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 7ed1cd2 must be in the format Fixes/refs #redmine_number - brief description.
  • b6a4ecb must be in the format Fixes/refs #redmine_number - brief description.
  • 1f77e73 must be in the format Fixes/refs #redmine_number - brief description.
  • 30629af must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@adamruzicka adamruzicka mentioned this pull request Aug 19, 2015
Merged
ohadlevy
ohadlevy reviewed Aug 19, 2015
View reviewed changes
app/lib/actions/middleware/keep_current_user.rb
end

def store_current_user
action.input[:current_user_id] = User.current.id unless User.current.nil?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User.try(:current) ?

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 7ed1cd2 must be in the format Fixes/refs #redmine_number - brief description.
  • b6a4ecb must be in the format Fixes/refs #redmine_number - brief description.
  • 1f77e73 must be in the format Fixes/refs #redmine_number - brief description.
  • 30629af must be in the format Fixes/refs #redmine_number - brief description.

Guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member

iNecas commented Sep 1, 2015

Didn't go though the whole, but the testing went pretty well so far

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 7ed1cd2 must be in the format fixes #redmine_number - brief description.
  • b6a4ecb must be in the format fixes #redmine_number - brief description.
  • 1f77e73 must be in the format fixes #redmine_number - brief description.
  • 30629af must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member

iNecas commented Sep 15, 2015

[test]

@iNecas
Copy link
Member

iNecas commented Sep 15, 2015

I've tested the code and it works as expected, ACK (expected the CI passing and the commits properly assigned to issues), squash allowed :)

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 7ed1cd2 must be in the format fixes #redmine_number - brief description.
  • b6a4ecb must be in the format fixes #redmine_number - brief description.
  • 1f77e73 must be in the format fixes #redmine_number - brief description.
  • 30629af must be in the format fixes #redmine_number - brief description.

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@adamruzicka
Copy link
Contributor Author

CI is green, rebased, squashed, commits properly assigned

@iNecas
Copy link
Member

iNecas commented Sep 16, 2015

Ok, so we're waiting for this one now, right? Dynflow/dynflow#170

@adamruzicka
Refs #10753 - Support for setting future time of execution
b52a8cb 
  - Fix KeepCurrentUser middleware
  - Use active record serializer as default serializer
  - Make dynflow task accessible in delay
  - Raise custom exception on task cancel
@iNecas iNecas merged commit b52a8cb into theforeman:master Sep 17, 2015
@iNecas
Copy link
Member

iNecas commented Sep 17, 2015

I've updated the dependency on dynflow and merged, thanks @adamruzicka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
4 participants
@adamruzicka @theforeman-bot @iNecas @ohadlevy