New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #15515 - Fix undefined method get_humanized for nil:NilClass #190
Fixes #15515 - Fix undefined method get_humanized for nil:NilClass #190
Conversation
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
The above fix will prevent the exception being raised while invoking format_task_input method with nil param in the below files- /views/foreman_tasks/recurring_logics/index.html.erb /views/foreman_tasks/task_groups/recurring_logic_task_groups/_recurring_logic_task_group.html.erb |
[test] |
@@ -15,6 +15,9 @@ class TasksHelperTest < ActionView::TestCase | |||
format_task_input(@task, true).must_equal("Create user 'Anonymous Admin'") | |||
end | |||
|
|||
it 'displays the dash if task is nul' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick if the task is nil
4fb2ed1
to
6c65514
Compare
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
@theforeman-bot complains about the commit message size. Not that I like this policy too much, but still, let's make him happy :) |
[test] |
@iNecas keep in mind you can cherry-pick & |
I know but I preffer to teach how to fish instead :) On Tuesday, June 28, 2016, Daniel Lobato García notifications@github.com
|
I will not block this on just on the lenght of the commit message (I've updated that while merging). Thanks @vision2910 |
No description provided.