Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15515 - Fix undefined method get_humanized for nil:NilClass #190

Merged

Conversation

vision2910
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 4fb2ed1 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@vision2910
Copy link
Contributor Author

The above fix will prevent the exception being raised while invoking format_task_input method with nil param in the below files-

/views/foreman_tasks/recurring_logics/index.html.erb

/views/foreman_tasks/task_groups/recurring_logic_task_groups/_recurring_logic_task_group.html.erb

@iNecas
Copy link
Member

iNecas commented Jun 24, 2016

[test]

@@ -15,6 +15,9 @@ class TasksHelperTest < ActionView::TestCase
format_task_input(@task, true).must_equal("Create user 'Anonymous Admin'")
end

it 'displays the dash if task is nul' do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick if the task is nil

@vision2910 vision2910 force-pushed the foreman-task-get_humize_for_nil-fix branch from 4fb2ed1 to 6c65514 Compare June 27, 2016 04:29
@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 6c65514 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine, selecting the appropriate project.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member

iNecas commented Jun 27, 2016

@theforeman-bot complains about the commit message size. Not that I like this policy too much, but still, let's make him happy :)

@iNecas
Copy link
Member

iNecas commented Jun 28, 2016

[test]

@dLobatog
Copy link
Member

@iNecas keep in mind you can cherry-pick & commit --amend to fix it in these situations 😄

@iNecas
Copy link
Member

iNecas commented Jun 28, 2016

I know but I preffer to teach how to fish instead :)

On Tuesday, June 28, 2016, Daniel Lobato García notifications@github.com
wrote:

@iNecas https://github.com/iNecas keep in mind you can cherry-pick & commit
--amend to fix it in these situations 😄


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#190 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AALn6_nMqSe9qwh-En5L-iCndqG8LUiwks5qQPIxgaJpZM4I9r5N
.

@iNecas iNecas merged commit dc19edb into theforeman:master Jul 22, 2016
@iNecas
Copy link
Member

iNecas commented Jul 22, 2016

I will not block this on just on the lenght of the commit message (I've updated that while merging). Thanks @vision2910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants