Fix tests and rubocop against latest develop #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
|
This also tries to fix latest rubocop issues:master is red at the moment, watching at http://ci.theforeman.org/job/test_plugin_pull_request/3645/ |
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
|
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
theforeman-bot
added
Needs testing
Waiting on contributor
and removed
Waiting on contributor
labels
iNecas
changed the title
|
Removed the debugging prints and waiting for jenkins to prove it fixes the recent failures http://ci.theforeman.org/job/test_plugin_pull_request/3656/ |
adamruzicka
approved these changes
Apr 27, 2017
|
@iNecas the tests are green. Anything else to add here or can I merge it? |
|
If only all the plugins were this green. Thanks for reviewing, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.