Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #18356 - Assume incoming output is UTF-8 #254

Closed
wants to merge 1 commit into from

Conversation

adamruzicka
Copy link
Contributor

net-ssh read the data as bytes and assumes it is ASCII-8BIT encoded. Sadly we have no reliable way of detecting the encoding of the incoming data.

@theforeman-bot
Copy link
Member

@adamruzicka, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).


This message was auto-generated by Foreman's prprocessor

@@ -42,7 +42,7 @@ def close
end

def publish_data(data, type)
@continuous_output.add_output(data, type)
@continuous_output.add_output(data.force_encoding('UTF-8'), type)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we override the publish_method in rex to call super(data.force_endocing('UTF-8'), type) there

@theforeman-bot
Copy link
Member

@adamruzicka, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).


This message was auto-generated by Foreman's prprocessor

@adamruzicka
Copy link
Contributor Author

Closing since this can be done on REX's side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants