Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #20917 - Started field should show timestamp #280

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

snagoor
Copy link
Contributor

@snagoor snagoor commented Sep 14, 2017

Started filed should show timestamps rather than the time it was running. Feature request was more of the timestamp in the "latest warning/error tasks" widget.

Also as a end user, I see only the latest 5 tasks in the widget, where timestamp would be more feasible rather than when it was started. See image below

Latest Warning / Errors Tasks

@adamruzicka
Copy link
Contributor

where timestamp would be more feasible rather than when it was started.

But even with you're patch it is still showing "when it was started", it is just more precise. Also the benefit of exact representation (On Oct 25 12:10) over approximate representation in words (20 days ago) is quite arguable.

@iNecas
Copy link
Member

iNecas commented Sep 14, 2017

Since we just merged theforeman/foreman#4820, I think the new helpers should be used instead. It also show relative vs. absolute value in tooltip, which should help both sides of the argument to find the right value quickly. So I suggest starting using date_time_relative helper, which provides the absolute value in the tooltip, so that both information are available.

I agree with adam, that the relative information is more useful here to see if the info there is something that happened today/yesterday, or 60 days ago.

@iNecas
Copy link
Member

iNecas commented Sep 14, 2017

Please also use Refs, instead of Fixes, as the original issue was already fixed, or file different issue

@snagoor snagoor changed the title Fixes #20917 - Started field should show timestamp Refs #20917 - Started field should show timestamp Sep 15, 2017
@snagoor
Copy link
Contributor Author

snagoor commented Sep 15, 2017

@iNecas, I made the changes as per the new helper date_time_relative. Can you have another look. Here is the sample image

screenshot from 2017-09-15 15-20-17

@snagoor
Copy link
Contributor Author

snagoor commented Sep 15, 2017

Modified both Latest Warning/Error Tasks and Task Status widgets with new date_time_relative helper

@iNecas
Copy link
Member

iNecas commented Sep 19, 2017

Looks good. Waiting for stable builds + 1.16 RC builds so that we are sure the helpers are already there before merging this one.

@iNecas
Copy link
Member

iNecas commented Oct 6, 2017

I've checked and the helpers are now officially in 1.16. This one is good to go

@iNecas iNecas merged commit 235fff6 into theforeman:master Oct 6, 2017
@iNecas
Copy link
Member

iNecas commented Oct 6, 2017

Thanks @snagoor !

@ares
Copy link
Member

ares commented Oct 9, 2017

@iNecas I think this should have bumped the required Foreman version https://github.com/theforeman/foreman-tasks/blob/master/lib/foreman_tasks/engine.rb#L44

also this will need a change in packaging when new version is built

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants