Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22887 - update persistence initialization code #319

Merged
merged 2 commits into from Mar 30, 2018
Merged

Fixes #22887 - update persistence initialization code #319

merged 2 commits into from Mar 30, 2018

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Mar 13, 2018

This was referenced Mar 13, 2018
Merged
Merged
adamruzicka
adamruzicka reviewed Mar 14, 2018
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to review here, works as expected, waiting for dependencies.

adamruzicka
adamruzicka requested changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now know the Dynflow release containing support for queues will be 0.9.0, could you please bump the dependency?

@iNecas
Copy link
Member Author

iNecas commented Mar 27, 2018

Updated

adamruzicka
adamruzicka approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on dependencies, there is a merge conflict but I can resolve that on merge

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 17b5867 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

@adamruzicka
Copy link
Contributor

Could you please bump the Dynflow dependency again?

@iNecas
Copy link
Member Author

iNecas commented Mar 29, 2018

Updated

@theforeman theforeman deleted a comment from theforeman-bot Mar 29, 2018
@theforeman theforeman deleted a comment from theforeman-bot Mar 29, 2018
@adamruzicka
Copy link
Contributor

Thanks for the rebase, APJ

@adamruzicka
Copy link
Contributor

Looks like we will need to open a PR to foreman core and bump Dynflow version there

@iNecas
Copy link
Member Author

iNecas commented Mar 29, 2018

Here we go theforeman/foreman#5320

@mmoll
Copy link
Contributor

mmoll commented Mar 30, 2018

this should go in now 👍

@mmoll
Copy link
Contributor

mmoll commented Mar 30, 2018

💚

@adamruzicka adamruzicka merged commit 5aafcf0 into theforeman:master Mar 30, 2018
@adamruzicka
Copy link
Contributor

Thanks @iNecas !

@mmoll
Copy link
Contributor

mmoll commented Mar 30, 2018

could we have a release with this?

@iNecas iNecas deleted the persistence_class branch April 3, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmoll mmoll mmoll approved these changes

@adamruzicka adamruzicka adamruzicka approved these changes

Assignees
No one assigned
Labels
Needs testing Waiting on contributor Waiting on Dependencies
Projects
None yet
Milestone
No milestone
4 participants
@iNecas @theforeman-bot @adamruzicka @mmoll