Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22920 - Access variable, not datastructure #322

Merged
merged 1 commit into from Mar 19, 2018
Merged

Fixes #22920 - Access variable, not datastructure #322

merged 1 commit into from Mar 19, 2018

Conversation

bjozet
Copy link
Contributor

@bjozet bjozet commented Mar 17, 2018

Was seeing a lot of errors like:

NoMethodError: undefined method `>' for <Foreman::Version:0x....

String comparison was being attempted against the datastructure, not
the actual variable.

@bjozet
Fixes #22920 - Access variable, not datastructure
e1e3966 
Was seeing a lot of errors like:

NoMethodError: undefined method `>' for <Foreman::Version:0x....

String comparison was being attempted against the datastructure, not
the actual variable.
@mmoll
Copy link
Contributor

mmoll commented Mar 17, 2018

ok to test

@mmoll
Copy link
Contributor

mmoll commented Mar 17, 2018

[test]

@mmoll
Copy link
Contributor

mmoll commented Mar 17, 2018

test failure unrelated

@iNecas
Copy link
Member

iNecas commented Mar 19, 2018

Thanks @bjozet

@iNecas iNecas merged commit e6fd64b into theforeman:master Mar 19, 2018
@bjozet bjozet deleted the import_facts_bug branch March 19, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs testing Not yet reviewed
Projects
None yet
Milestone
No milestone
4 participants
@bjozet @mmoll @iNecas @theforeman-bot