Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24895 - Enable the KeepCurrentTaxonomies middleware globally #360

Merged
merged 2 commits into from Oct 5, 2018

Conversation

adamruzicka
Copy link
Contributor

No description provided.

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 9f4df84 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@jlsherrill
Copy link
Contributor

[test foreman-tasks]

1 similar comment
@adamruzicka
Copy link
Contributor Author

[test foreman-tasks]

@iNecas
Copy link
Member

iNecas commented Oct 2, 2018

@adamruzicka is this actually fixing the issue in Rex for you? I see the current_{organization,location} field added, but it's empty:

current_organization_id: 
current_location_id: 

What I did is:

  1. schedule the recurring job with taxonomy set
  2. wait for second iteration
  3. ended up with 431% failed hosts (even though total hosts mentions 35 hosts)

rex-failure

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 7116ccc exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@adamruzicka
Copy link
Contributor Author

Rebased on top of #367

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 7116ccc exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 7116ccc exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 7116ccc exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member

iNecas commented Oct 5, 2018

Rebase needed

@adamruzicka
Copy link
Contributor Author

Rebased

@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • length of the first commit message line for 4d3affc exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@iNecas
Copy link
Member

iNecas commented Oct 5, 2018

Thanks @adamruzicka

@iNecas iNecas merged commit d514a70 into theforeman:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants