Fixes #25282 - Create a task for each target even if missing #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requires Dynflow/dynflow#299 to fix the issue fully |
|
[test foreman-tasks] |
iNecas
reviewed
Dec 7, 2018
We always assumed we will get all targets from the DB. If some of the targets were missing in the DB, we didn't create the task for it and it lead to task counters going out of sync. With this patch we create tasks for missing targets, but pass nil instead of the target to it.
|
Dynflow 1.1.5, including the dependent change, got released. After bumping the version requirement here, plus fixing the one comment I had, this would be good to go. |
adamruzicka
force-pushed
the
fix/25282-missing-batch
branch
from
5a02540
to
1562a47
Compare
|
This PR is 🍏 |
|
Thanks @adamruzicka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always assumed we will get all targets from the DB. If some of
the targets were missing in the DB, we didn't create the task for
it and it lead to task counters going out of sync.
With this patch we create tasks for missing targets, but pass nil
instead of the target to it.