-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #25958 - incorrect value for auto_complete_controller_name #387
Conversation
There were the following issues with the commit message:
If you don't have a ticket number, please create an issue in Redmine. More guidelines are available in Coding Standards or on the Foreman wiki. This message was auto-generated by Foreman's prprocessor |
Do not merge! This patch has not been tested yet. Can an existing organization member please verify this patch? |
/foreman_tasks/tasks should be foreman_tasks_tasks
@alanwevans, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:
If changing the ticket number used, remember to update the PR title and the commit message (using This message was auto-generated by Foreman's prprocessor |
@@ -98,7 +98,7 @@ def resource_class | |||
end | |||
|
|||
def auto_complete_controller_name | |||
'/foreman_tasks/tasks' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code has actually been added in #375 to workaround regression introduced in theforeman/foreman#5771. It seems that it has not fixed the issue properly.
In order for this fix to work, we need also theforeman/foreman#6460.
After that is merged, we can just remove the auto_complete_controller_name method complete from here, so that it would work as before #375.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The foreman PR has just been merge. Mind updating the PR to just remove this method completely? That should fix the whole problem.
Thanks alan for reporting and fixing the issue. Unfortunately, we also need a change in foreman to make this work. After that is done, we don't need |
Closing in favor of https://github.com/theforeman/foreman-tasks/pull/388/files : currently the tasks are broken in nightlies: we should be moving quickly to unblock other developers |
/foreman_tasks/tasks should be foreman_tasks_tasks
Fixes https://projects.theforeman.org/issues/25958