Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #26343 - Create card for stopped tasks and scheduled tasks #395

Closed
wants to merge 1 commit into from
Closed

Fixes #26343 - Create card for stopped tasks and scheduled tasks #395

wants to merge 1 commit into from

Conversation

MariaAga
Copy link
Member

@MariaAga MariaAga commented Mar 13, 2019 •
edited

@theforeman-bot
Copy link
Member

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@MariaAga MariaAga force-pushed the feature/tasks-stopped-scheduled-cards branch 3 times, most recently from 430ef6a to d4367c1 Compare March 14, 2019 16:17
waldenraines
waldenraines suggested changes Mar 15, 2019
View reviewed changes
Copy link

@waldenraines waldenraines left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have a couple of small comments and a couple of questions.

In there stopped tasks table is there a way to unselect your selection? Like maybe clicking outside of the table would unselect your prior selection?

Another (perhaps future) enhancement could be to allow control+click to select multiple states but I don't think we should support that initially.

@Rohoover, @terezanovotna thoughts?

...k/ForemanTasks/Components/TasksDashboard/Components/ScheduledTasksCard/ScheduledTasksCard.js Outdated
className
)}
>
<Card.Title onClick={this.onClick}>Scheduled</Card.Title>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to translate this string.

@waldenraines
Copy link

@MariaAga could you deploy this to gh pages for @Rohoover and @terezanovotna to have a look?

@MariaAga MariaAga changed the title Create card for stopped tasks and scheduled tasks Fixes #26343 - Create card for stopped tasks and scheduled tasks Mar 18, 2019
@MariaAga MariaAga force-pushed the feature/tasks-stopped-scheduled-cards branch from d4367c1 to c08606d Compare March 19, 2019 12:01
sharvit
sharvit suggested changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MariaAga 👍

...k/ForemanTasks/Components/TasksDashboard/Components/ScheduledTasksCard/ScheduledTasksCard.js Outdated Show resolved Hide resolved
...emanTasks/Components/TasksDashboard/Components/ScheduledTasksCard/ScheduledTasksCard.test.js Outdated Show resolved Hide resolved
webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated Show resolved Hide resolved
webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated Show resolved Hide resolved
webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated Show resolved Hide resolved
webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated Show resolved Hide resolved
webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated Show resolved Hide resolved
webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated Show resolved Hide resolved
...ack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.scss Outdated Show resolved Hide resolved
...emanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCardConstants.js Outdated Show resolved Hide resolved
@MariaAga MariaAga force-pushed the feature/tasks-stopped-scheduled-cards branch from c08606d to 6398b9a Compare March 21, 2019 15:53
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

sharvit
sharvit suggested changes Mar 24, 2019
View reviewed changes
Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MariaAga, can you please deploy the storybook using:

npm run storybook:build
npm run storybook:deploy

webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated Show resolved Hide resolved
webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated Show resolved Hide resolved
webpack/ForemanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCard.js Outdated
});

const resultPropType = PropTypes.shape({
total: PropTypes.shape({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shape can be reused as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make everything required here can help when reading the data. (won't need to do warrning.total && warning.total.value)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already required, and I couldn't find a place that uses warning.total && warning.total.value

...oremanTasks/Components/TasksDashboard/Components/StoppedTasksCard/StoppedTasksCardHelpers.js Outdated Show resolved Hide resolved
@MariaAga MariaAga force-pushed the feature/tasks-stopped-scheduled-cards branch from 6398b9a to 9acb5c3 Compare March 24, 2019 10:39
@MariaAga MariaAga force-pushed the feature/tasks-stopped-scheduled-cards branch from 9acb5c3 to 8c465e8 Compare March 25, 2019 15:01
sharvit
sharvit approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MariaAga LGTM 👍

@sharvit
Copy link
Contributor

sharvit commented Mar 25, 2019

@MariaAga notice snapshot error

@MariaAga MariaAga force-pushed the feature/tasks-stopped-scheduled-cards branch from 8c465e8 to c8a1566 Compare March 25, 2019 15:50
@MariaAga
Copy link
Member Author

@sharvit Fixed, thanks!

@MariaAga
Merge pull request #1 from sharvit/feature/tasks-card-stopped-state
17877de 
Refs #26406 - Update pause and stopped cards
@theforeman-bot
Copy link
Member

There were the following issues with the commit message:

  • 17877de must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 17877de exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

sharvit
sharvit approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@sharvit sharvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iNecas
Copy link
Member

iNecas commented Apr 2, 2019

Rebased and merged

@iNecas iNecas closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waldenraines waldenraines waldenraines requested changes

@sharvit sharvit sharvit approved these changes

Assignees
No one assigned
Labels
Needs testing Waiting on contributor
Projects
None yet
Milestone
No milestone
5 participants
@MariaAga @theforeman-bot @waldenraines @sharvit @iNecas