Refs #22602 - explicit instead of implicit casting UUID casting #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In production setup, we were getting:
create cast must be owner of type character varying
The problem is this casting seems to be global, and we might not want
to do that for every case, and we don't have permissions for that.
iNecas
commented
May 7, 2019
| # We can't use transactional tests because we're using Sequel for the cleanup query | ||
| self.use_transactional_tests = false | ||
| before do | ||
| skip "Sqlite is running testing Dynlfow DB in memory" if ActiveRecord::Base.connection.adapter_name == 'SQLite' |
There was a problem hiding this comment.
We can't test the cleaner in sqite, because ActiveRecord and Sequel are running in separate DBs
adamruzicka
approved these changes
May 7, 2019
|
JP (well, one is still running, but it already passed the tasks tests) |
|
Alright, let's get it it |
|
Thanks @iNecas ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production setup, we were getting:
The problem is this casting seems to be global, and we might not want
to do that for every case, and we don't have permissions for that.