Fixes #27272 - ajax load for table data from dashboard actions

[iNecas]

No description provided.

[adamruzicka]

The user experience is now much better, ACK

[adamruzicka]

TIL there's for item in collection syntax in ruby

[iNecas]

[ares]

8-O (applies to both comments)

[ares]

should this hide spinner too?

[iNecas]

Isn't that handled by the complete callback?

[adamruzicka]

Looks like it is

[adamruzicka]

Needs a rebase

[iNecas]

Rebased

[adamruzicka]

Works well, ACK

[adamruzicka]

Thanks @iNecas !

[sharvit]

Thanks to everyone who contributed to this PR.

We are planning for moving the table to react and use react-router to update this table.
AFAIK @MariaAga is already working on it and have great progress.

Notice the resolveQuery designed to be a workaround and to be removed once we implement the new table with react.

So is this PR need to be reverted eventually?
Should it be removed as part of @MariaAga work?

I feel like @MariaAga had to be involved in this discussion.

[sharvit]

Using variables from the window object considre a bad practice in webpack.
Better doing import $ from 'jquery';

About the tfm, it designed to be the bridge between webpack and the assets pipeline so we can slowly replace old code in the assets gradually. It considers wrong to use this object inside webpack.

[sharvit]

It considered wrong to use the showSpinner from the tfm object. Instead, something like this should be done in the action:

import { showSpinner, hideSpinner } from 'foremanReact/components/Layout/LayoutActions';

// inside an action
const myAction = () => async (dispatch) => {
  try {
    dispatch(showSpinner());
    disptach(requestStarted());

    const results = await API.get(...);
    dispatch(requestSucceed(results));
  } catch (error) {
    dispatch(requestError(error));
  }

    dispatch(hideSpinner());
};

[sharvit]

Using the ajax function from jquery considre wrong, in webpack we prefer to use the shared: https://github.com/theforeman/foreman/blob/ac1fe0de56f29d834a54a96d069231a823878ed3/webpack/assets/javascripts/react_app/API.js

• It might not work for this case because the API designed to receive jsons.

[iNecas]

@sharvit exactly: this is purely to provide a short-term workaround for the ugly behavior we had there before and I'm all for removing this once @MariaAga's work is ready.