Fixes #32729 - reload setting prior run #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Foreman we've switched to in-memory setting cache, that needs to be reloaded on demand, Rails is doing that on every request, for dynflow actions we need to do it on every phase.
To include it also in ActiveJob
|
Nice, thanks @ShimShtein, but could you rebase on top of my new changes? I believe we don't need to bump the version just for this, we can just not reload settings on lower versions. |
|
Thank you @ShimShtein , changes from here got pulled back into #636 , closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the modification of #636 to include the fix also in ActiveJob based tasks.