Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #35950 - Make delivery of ProxyActionStopped events optional #704

Merged
merged 1 commit into from Jan 17, 2023

Conversation

adamruzicka
Copy link
Contributor

They are meant to catch cases when the remote task stops or disappears. If this happens but the local task is already stopped, it is not an error state.

They are meant to catch cases when the remote task stops or disappears.
If this happens but the local task is already stopped, it is not an
error state.
Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to reproduce, but this doesn't seem like a breaking change, so LGTM.

@ofedoren ofedoren merged commit 45decf9 into theforeman:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants