Skip to content

Commit

Permalink
move puppet specific methods to PuppetReport class
Browse files Browse the repository at this point in the history
  • Loading branch information
shlomizadok committed Jul 8, 2015
1 parent ebabb46 commit 537f01e
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 13 deletions.
11 changes: 11 additions & 0 deletions app/models/puppet_report.rb
Expand Up @@ -6,4 +6,15 @@ def self.model_name
def self.import(report, proxy_id = nil)
PuppetReportImporter.import(report, proxy_id)
end

def summaryStatus
return _("Failed") if error?
return _("Modified") if changes?
_("Success")
end

# puppet report status table column name
def self.report_status
"status"
end
end
13 changes: 1 addition & 12 deletions app/models/report.rb
Expand Up @@ -84,7 +84,7 @@ def runtime

def self.import(report, proxy_id = nil)
#raise NotImplementedError
Foreman::Deprecation.deprecation_warning(1.11, "Reports should be... ")
Foreman::Deprecation.deprecation_warning(1.12, "Reports should be... ")
PuppetReportImporter.import(report, proxy_id)
end

Expand Down Expand Up @@ -134,17 +134,6 @@ def self.expire(conditions = {})
def no_report
false
end

def summaryStatus
return _("Failed") if error?
return _("Modified") if changes?
_("Success")
end

# puppet report status table column name
def self.report_status
"status"
end
end

require_dependency 'puppet_report'
Expand Down
2 changes: 1 addition & 1 deletion app/services/report_importer.rb
Expand Up @@ -10,7 +10,7 @@ def self.importers
@importers ||= { :puppet => PuppetReportImporter }.with_indifferent_access
end

def self.register_fact_importer(key, klass)
def self.register_report_importer(key, klass)
importers[key.to_sym] = klass
end

Expand Down

0 comments on commit 537f01e

Please sign in to comment.