fixes #26052 - navigation missing IDs

theforeman · May 16, 2019 · 68bda9e · 68bda9e
1 parent a8a8fdb
commit 68bda9e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/webpack/assets/javascripts/react_app/components/Layout/LayoutSelectors.js b/webpack/assets/javascripts/react_app/components/Layout/LayoutSelectors.js
@@ -1,5 +1,5 @@
 import { createSelector } from 'reselect';
-import { get } from 'lodash';
+import { get, snakeCase } from 'lodash';
 import { noop } from '../../common/helpers';
 
 export const selectLayout = state => state.layout;
@@ -29,6 +29,7 @@ const patternflyItems = (data, currentLocation, currentOrganization) => {
     const childrenArray = [];
     item.children.forEach(child => {
       const childObject = {
+        id: `menu_item_${snakeCase(child.name)}`,
         title: child.name,
         isDivider: child.type === 'divider' && !!child.name,
         className:

diff --git a/...ascripts/react_app/components/Layout/__tests__/__snapshots__/LayoutSelectors.test.js.snap b/...ascripts/react_app/components/Layout/__tests__/__snapshots__/LayoutSelectors.test.js.snap
@@ -93,6 +93,7 @@ Array [
       Object {
         "className": "",
         "href": "/",
+        "id": "menu_item_dashboard",
         "isDivider": false,
         "onClick": [Function],
         "preventHref": true,
@@ -101,6 +102,7 @@ Array [
       Object {
         "className": "",
         "href": "/fact_values",
+        "id": "menu_item_facts",
         "isDivider": false,
         "onClick": [Function],
         "preventHref": true,
@@ -116,6 +118,7 @@ Array [
       Object {
         "className": "",
         "href": "/hosts/new",
+        "id": "menu_item_all_hosts",
         "isDivider": false,
         "onClick": [Function],
         "preventHref": true,
@@ -124,6 +127,7 @@ Array [
       Object {
         "className": "",
         "href": "/architectures",
+        "id": "menu_item_architectures",
         "isDivider": false,
         "onClick": [Function],
         "preventHref": true,
@@ -139,6 +143,7 @@ Array [
       Object {
         "className": "",
         "href": "/environments",
+        "id": "menu_item_environments",
         "isDivider": false,
         "onClick": [Function],
         "preventHref": true,
@@ -147,6 +152,7 @@ Array [
       Object {
         "className": "",
         "href": "/architectures",
+        "id": "menu_item_architectures",
         "isDivider": false,
         "onClick": [Function],
         "preventHref": true,
@@ -162,6 +168,7 @@ Array [
       Object {
         "className": "",
         "href": "/domains",
+        "id": "menu_item_domains",
         "isDivider": false,
         "onClick": [Function],
         "preventHref": true,
@@ -170,6 +177,7 @@ Array [
       Object {
         "className": "",
         "href": "/realms",
+        "id": "menu_item_realms",
         "isDivider": false,
         "onClick": [Function],
         "preventHref": true,