fixes #10720 Adds API to get host vm attributes

Contributors

@@ -180,6 +180,7 @@ Trey Dockendorf <treydock@tamu.edu>
 Unknown <flo@WKS-W7-LDN-0034.tradition.int>
 Vanya Jauhal <vanyajauhal1995@gmail.com>
 Walden Raines <walden@redhat.com>
+Walter Huf <hufman@google.com>
 William Hutson <wilrnh@msn.com>
 abenari <abenari@redhat.com>
 cyberkov <admin@cyberkov.at>

app/controllers/api/v2/hosts_controller.rb

@@ -126,6 +126,30 @@ def status
         render :json => { :status => @host.host_status }.to_json if @host
       end
 
+      api :GET, "/hosts/:id/vm_compute_attributes", N_("Get vm attributes of host")
+      param :id, :identifier_dottable, :required => true
+      description <<-eos
+Return the host's compute attributes that can be used to create a clone of this VM
+      eos
+
+      def vm_compute_attributes
+        if @host
+          attrs = @host.vm_compute_attributes
+          safe_attrs = {}
+          attrs.each_pair do |k,v|
+            # clean up the compute attributes to be suitable for output
+            if v.is_a?(Proc)
+              safe_attrs[k] = v.call()
+            elsif v.respond_to?('parent')
+              # don't add folders, causes recursive json issues
+            else
+              safe_attrs[k] = v
+            end
+          end
+        end
+        render :json => { :compute_attributes => safe_attrs }.to_json if @host
+      end
+
       api :PUT, "/hosts/:id/puppetrun", N_("Force a Puppet agent run on the host")
       param :id, :identifier_dottable, :required => true
 
@@ -221,6 +245,8 @@ def action_permission
             :console
           when 'disassociate'
             :edit
+          when 'vm_compute_attributes'
+            :view
           else
             super
         end

app/models/host/managed.rb

@@ -660,6 +660,10 @@ def sp_name
     bmc_nic.try(:name)
   end
 
+  def vm_compute_attributes
+    compute_resource ? compute_resource.vm_compute_attributes_for(uuid) : nil
+  end
+
   def host_status
     if build
       N_("Pending Installation")

config/routes/api/v2.rb

@@ -268,6 +268,7 @@
         end
         resources :hosts, :except => [:new, :edit] do
           get :status, :on => :member
+          get :vm_compute_attributes, :on => :member
           put :puppetrun, :on => :member
           put :disassociate, :on => :member
           put :boot, :on => :member

test/functional/api/v2/hosts_controller_test.rb

@@ -252,6 +252,16 @@ def last_host
     assert_response :not_found
   end
 
+  test "should show hosts vm attributes" do
+    host = FactoryGirl.create(:host, :compute_resource => compute_resources(:one))
+    ComputeResource.any_instance.stubs(:vm_compute_attributes_for).returns( :cpus => 4 )
+    get :vm_compute_attributes, { :id => host.to_param }
+    assert_response :success
+    data = JSON.parse(@response.body)
+    assert_equal data, "compute_attributes" => { "cpus" => 4 }
+    ComputeResource.any_instance.unstub(:vm_compute_attributes_for)
+  end
+
   def set_remote_user_to(user)
     @request.env['REMOTE_USER'] = user.login
   end

test/unit/host_test.rb

@@ -147,6 +147,17 @@ class HostTest < ActiveSupport::TestCase
     host.update_attributes!(:mac => "52:54:00:dd:ee:ff")
   end
 
+  test "can fetch vm compute attributes" do
+    host = FactoryGirl.create(:host, :compute_resource => compute_resources(:one))
+    ComputeResource.any_instance.stubs(:vm_compute_attributes_for).returns({:cpus => 4})
+    assert_equal host.vm_compute_attributes, :cpus => 4
+  end
+
+  test "fetches nil vm compute attributes for bare metal" do
+    host = FactoryGirl.create(:host)
+    assert_equal host.vm_compute_attributes, nil
+  end
+
   context "when unattended is false" do
     def setup
       SETTINGS[:unattended] = false