fixes #1992 sort does not fail if vlanid is null

theforeman · Dec 24, 2012 · 9f9effa · 9f9effa
1 parent e210844
commit 9f9effa
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/app/models/subnet.rb b/app/models/subnet.rb
@@ -47,7 +47,11 @@ def title
   # [+other+] : Subnet object with which to compare ourself
   # +returns+ : Subnet object with higher precedence
   def <=> (other)
-    self.vlanid <=> other.vlanid
+    if self.vlanid.present? && other.vlanid.present?
+      self.vlanid <=> other.vlanid
+    else
+      return -1
+    end
   end
 
   # Given an IP returns the subnet that contains that IP