fixes #14076 - remove unused Puppetclass hostgroups counter

app/models/hostgroup_class.rb

@@ -5,7 +5,7 @@ class HostgroupClass < ActiveRecord::Base
 
   audited :associated_with => :hostgroup, :allow_mass_assignment => true
   belongs_to :hostgroup
-  belongs_to :puppetclass, :counter_cache => :hostgroups_count
+  belongs_to :puppetclass
 
   attr_accessible :hostgroup_id, :hostgroup, :puppetclass_id, :puppetclass
   validates :hostgroup, :presence => true

db/migrate/20160307120453_remove_hostgroups_count_from_puppetclasses.rb

@@ -0,0 +1,10 @@
+class RemoveHostgroupsCountFromPuppetclasses < ActiveRecord::Migration
+  def up
+    remove_column :puppetclasses, :hostgroups_count
+  end
+
+  def down
+    add_column :puppetclasses, :hostgroups_count, :integer, :default => 0
+    execute 'UPDATE puppetclasses SET hostgroups_count = (SELECT COUNT(*) FROM hostgroup_classes WHERE hostgroup_classes.puppetclass_id = puppetclasses.id)'
+  end
+end

test/unit/hostgroup_class_test.rb

@@ -15,12 +15,4 @@ class HostgroupClassTest < ActiveSupport::TestCase
       end
     end
   end
-
-  test "should update hostgroups_count" do
-    pc = puppetclasses(:two)
-    assert_difference "pc.hostgroups_count" do
-      HostgroupClass.create(:puppetclass_id => pc.id, :hostgroup_id => hostgroups(:common).id)
-      pc.reload
-    end
-  end
 end