fixes #7121 - move smart proxy action buttons to helper

theforeman · Aug 28, 2014 · da24313 · da24313
1 parent 3b4f386
commit da24313
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 15 deletions.
diff --git a/app/helpers/smart_proxies_helper.rb b/app/helpers/smart_proxies_helper.rb
@@ -0,0 +1,19 @@
+module SmartProxiesHelper
+  def proxy_actions proxy, authorizer
+    [if proxy.features.detect{|f| f.name == "Puppet CA"}
+       [display_link_if_authorized(_("Certificates"), hash_for_smart_proxy_puppetca_index_path(:smart_proxy_id => proxy).
+                                merge(:auth_object => proxy, :permission => 'view_smart_proxies_puppetca', :authorizer => authorizer)),
+        display_link_if_authorized(_("Autosign"), hash_for_smart_proxy_autosign_index_path(:smart_proxy_id => proxy).
+                                merge(:auth_object => proxy, :permission => 'view_smart_proxies_autosign', :authorizer => authorizer))]
+     end,
+
+     if SETTINGS[:unattended] and proxy.features.detect{|f| f.name == "DHCP" }
+       display_link_if_authorized(_("Import subnets"), hash_for_import_subnets_path(:smart_proxy_id => proxy))
+     end,
+
+     display_link_if_authorized(_("Refresh features"), hash_for_refresh_smart_proxy_path(:id => proxy).
+                               merge(:auth_object => proxy, :permission => 'edit_smart_proxies', :authorizer => authorizer), :method => :put),
+
+     display_delete_if_authorized(hash_for_smart_proxy_path(:id => proxy).merge(:auth_object => proxy, :authorizer => authorizer), :confirm => _("Delete %s?") % proxy.name)]
+  end
+end
diff --git a/app/views/smart_proxies/index.html.erb b/app/views/smart_proxies/index.html.erb
@@ -15,21 +15,7 @@
       <td><%= link_to_if_authorized proxy.name, hash_for_edit_smart_proxy_path(:id => proxy.id).merge(:auth_object => proxy, :authorizer => authorizer) %></td>
       <td><%=h proxy.url %></td>
       <td><%=h proxy.features.to_sentence %></td>
-      <td>
-        <% ca = proxy.features.detect{|f| f.name == "Puppet CA"} %>
-        <%= action_buttons(
-          if ca
-            display_link_if_authorized(_("Certificates"), hash_for_smart_proxy_puppetca_index_path(:smart_proxy_id => proxy).merge(:auth_object => proxy, :permission => 'view_smart_proxies_puppetca', :authorizer => authorizer))
-          end,
-          if ca
-            display_link_if_authorized(_("Autosign"), hash_for_smart_proxy_autosign_index_path(:smart_proxy_id => proxy).merge(:auth_object => proxy, :permission => 'view_smart_proxies_autosign', :authorizer => authorizer))
-          end,
-          if SETTINGS[:unattended] and proxy.features.detect{|f| f.name == "DHCP" }
-            display_link_if_authorized(_("Import subnets"), hash_for_import_subnets_path(:smart_proxy_id => proxy))
-          end,
-          display_link_if_authorized(_("Refresh features"), hash_for_refresh_smart_proxy_path(:id => proxy).merge(:auth_object => proxy, :permission => 'edit_smart_proxies', :authorizer => authorizer), :method => :put),
-          display_delete_if_authorized(hash_for_smart_proxy_path(:id => proxy).merge(:auth_object => proxy, :authorizer => authorizer), :confirm => _("Delete %s?") % proxy.name))%>
-      </td>
+      <td><%= action_buttons(*proxy_actions(proxy, authorizer)) %></td>
     </tr>
   <% end %>
 </table>