Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37069 - Fallback to UTC on invalid timezone #10000

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

ofedoren
Copy link
Member

No description provided.

@sbernhard
Copy link
Contributor

Nice PR for the 10.000 PR :-)

@evgeni
Copy link
Member

evgeni commented Jan 25, 2024

[test katello]

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, as the 10000th pr should be

@adamruzicka
Copy link
Contributor

[test katello] for a good measure

@adamruzicka
Copy link
Contributor

The only failure in katello test suite is

[2024-03-15T11:49:44.233Z] unsatisfied expectations:
[2024-03-15T11:49:44.233Z] - expected exactly once, invoked twice: #<Katello::Api::V2::ContentViewVersionsController:0x8cca80>.async_task(Actions::Katello::ContentView::Promote, #<Katello::ContentViewVersion:0x8ccb70>, [#<Katello::KTEnvironment:0x8ccb98>], false, nil)

It can't possibly be caused by this change, merging.

@adamruzicka adamruzicka merged commit be92fd2 into theforeman:develop Mar 15, 2024
17 of 18 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ofedoren and sorry for the wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants