Fixes #37231 - Append domain name setting follow-up #10014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
stejskalleos
requested changes
Feb 14, 2024
Dyrkon
force-pushed
the
mm/append_domain_name_core_followup
branch
from
e37997b
to
b58dcb2
Compare
Dyrkon
force-pushed
the
mm/append_domain_name_core_followup
branch
3 times, most recently
from
b47693b
to
5c00136
Compare
|
I see it's still in WIP, any blockers here? |
Yes, there is some internal dispute regarding the way we are going to resolve this. |
Dyrkon
force-pushed
the
mm/append_domain_name_core_followup
branch
from
5c00136
to
4b800dd
Compare
Dyrkon
changed the title
stejskalleos
approved these changes
Mar 27, 2024
|
Thanks @Dyrkon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up fixes.