-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refs #37010 - Ensure correct yaml for netplan #10036
Conversation
f3a3724
to
31ad404
Compare
Katello tests seem unrelated AFAIK. |
31ad404
to
7853653
Compare
app/views/unattended/provisioning_templates/snippet/preseed_netplan_setup.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/snippet/preseed_netplan_setup.erb
Outdated
Show resolved
Hide resolved
app/views/unattended/provisioning_templates/snippet/preseed_netplan_setup.erb
Outdated
Show resolved
Hide resolved
7853653
to
973dae9
Compare
@sbernhard you're right with your comments. I've changed the corresponding lines. |
The introduced safe operator returns nil instead of false, but the snippet expects true/false.
973dae9
to
666e823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sbernhard you can only merge with
Apologies for missing this. I'd actually say the easier fix is to enforce a boolean in |
The changes in #9967 introduce the save navigation operator. Unfortunately, the corresponding snippet relies on the passed arguments being
true
/false
instead ofnil
.@ekohl should we add a safety check to the
preseed_netplan_generic_interface
that turnsnil
intofalse
or revert the save navigator change in this snippet?Or am I overseeing something here?