Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37150 - Race condition in edit smart proxy test #10041

Merged

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Feb 7, 2024

No description provided.

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

2 similar comments
@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@theforeman-bot
Copy link
Member

Can one of the admins verify this patch?

@ekohl
Copy link
Member

ekohl commented Feb 7, 2024

Ok to test

@stejskalleos
Copy link
Contributor

[test katello]

@stejskalleos stejskalleos self-assigned this Feb 15, 2024
@stejskalleos
Copy link
Contributor

Integration tests are failing on:

    test/integration_test_helper.rb:302:in `login_admin'
    test/integration_test_helper.rb:331:in `before_setup',Selenium::WebDriver::Error::InvalidSessionIdError: invalid session id

Guess it's not related to this changes, let's if they'll fail on rerun again

@dosas
Copy link
Contributor Author

dosas commented Feb 19, 2024

@stejskalleos Looks to me like the integration tests are failing all over the place for some time now.
https://github.com/theforeman/foreman/actions/runs/7934552063
I would be surprised it rerun works.

@stejskalleos
Copy link
Contributor

Yeah without green CI I can't be sure that this actually fixes the issue.
cc @ekohl @evgeni

@evgeni
Copy link
Member

evgeni commented Feb 20, 2024

you can temporarily pull in the changes from #10034 and see if things pass.

chrome 122 is supposed to be released today and fix the issue (fingers crossed)

@dosas dosas force-pushed the fix/race-condition-smart-proxy-test branch from fdf41dc to 703ba98 Compare February 20, 2024 08:57
@dosas
Copy link
Contributor Author

dosas commented Mar 12, 2024

@evgeni Are there any news on the chromedriver? The PR you mentioned above is still a draft.
Should I rebase?

@evgeni
Copy link
Member

evgeni commented Mar 12, 2024

Yes, rebase please, there is now a fixed chrome deployed.

@dosas dosas force-pushed the fix/race-condition-smart-proxy-test branch from 703ba98 to 2d7b283 Compare March 12, 2024 08:28
@evgeni evgeni merged commit 88baad9 into theforeman:develop Mar 12, 2024
40 checks passed
@evgeni
Copy link
Member

evgeni commented Mar 12, 2024

Thanks @dosas and sorry it took way too long for a one-liner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants