Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #3600 Replace / in bookmark name with _ #1006

Closed
wants to merge 1 commit into from

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Nov 7, 2013

Fix for #3600. When a user creates a bookmark name that has a "/", it breaks the bookmarks page. The user would then have to delete the entry manually from the database. This fixes that be replacing "/" in a bookmark name with "_".

Not sure if you'd prefer to error out and tell the user not to use "/"'s instead. Maybe that's the better solution.

@domcleal
Copy link
Contributor

domcleal commented Nov 7, 2013

Ah, thanks for the PR @stbenjam. We're going to fix this via #988 instead which will avoid using / in URL resource identifiers, so you'll still be permitted to include them in the bookmark names.

@domcleal domcleal closed this Nov 7, 2013
@stbenjam stbenjam deleted the fix_for_3600 branch May 14, 2014 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants