Fix Style/SoleNestedConditional cop #10068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nofaralfasi
requested changes
Feb 22, 2024
nofaralfasi
reviewed
Feb 22, 2024
| @@ -13,9 +13,9 @@ def resource_scope(options = {}) | |||
| protected | |||
|
|
|||
| def clear_session_locale_on_update | |||
| if params[:user] && editing_self? | |||
| if params[:user] && editing_self? && params[:user][:locale].try(:empty?) | |||
There was a problem hiding this comment.
Suggested change
| if params[:user] && editing_self? && params[:user][:locale].try(:empty?) | |
| user_params = params[:user] | |
| if user_params && editing_self? && user_params[:locale].blank? |
nofaralfasi
reviewed
Feb 22, 2024
| @@ -619,11 +619,9 @@ def create_interfaces(vm, attrs, cluster_id) | |||
| raise Foreman::Exception.new("Interface network or vnic profile are missing.") if (interface[:network].nil? && interface[:vnic_profile].nil?) | |||
| interface[:network] = get_ovirt_id(cluster_networks, 'network', interface[:network]) if interface[:network].present? | |||
| interface[:vnic_profile] = get_ovirt_id(profiles, 'vnic profile', interface[:vnic_profile]) if interface[:vnic_profile].present? | |||
| if (interface[:network].present? && interface[:vnic_profile].present?) | |||
| unless (profiles.select { |profile| profile.network.id == interface[:network] }).present? | |||
| if (interface[:network].present? && interface[:vnic_profile].present?) && !(profiles.select { |profile| profile.network.id == interface[:network] }).present? | |||
There was a problem hiding this comment.
Suggested change
| if (interface[:network].present? && interface[:vnic_profile].present?) && !(profiles.select { |profile| profile.network.id == interface[:network] }).present? | |
| if interface[:network].present? && interface[:vnic_profile].present? && profiles.none? { |profile| profile.network.id == interface[:network] } | |
nofaralfasi
reviewed
Feb 22, 2024
| @@ -9,12 +9,10 @@ class << base | |||
| module ClassMethods | |||
| # ensures that the correct STI object is created when :type is passed. | |||
| def new(attributes = nil, &block) | |||
| if attributes.is_a?(Hash) && (type = attributes.with_indifferent_access.delete(:type)) && !type.empty? | |||
| if (klass = type.constantize) != self | |||
| if attributes.is_a?(Hash) && (type = attributes.with_indifferent_access.delete(:type)) && !type.empty? && ((klass = type.constantize) != self) | |||
There was a problem hiding this comment.
Suggested change
| if attributes.is_a?(Hash) && (type = attributes.with_indifferent_access.delete(:type)) && !type.empty? && ((klass = type.constantize) != self) | |
| if attributes.is_a?(Hash) && (type = attributes.with_indifferent_access.delete(:type)).present? && (klass = type.constantize) != self |
nofaralfasi
reviewed
Feb 22, 2024
| unless q.nil? | ||
| if processed > 0 | ||
| # rubocop:enable Rails/FindEach | ||
| if !q.nil? && (processed > 0) |
There was a problem hiding this comment.
Suggested change
| if !q.nil? && (processed > 0) | |
| if q && processed.positive? |
nofaralfasi
reviewed
Feb 22, 2024
Comment on lines
+26
to
28
| if @condition.present? && !@condition.call | ||
| return | ||
| end |
There was a problem hiding this comment.
Suggested change
| if @condition.present? && !@condition.call | |
| return | |
| end | |
| return if @condition.present? && !@condition.call |
nofaralfasi
reviewed
Feb 22, 2024
Comment on lines
+50
to
52
| if notification_already_exists?(item) && !@force_repost | ||
| next | ||
| end |
There was a problem hiding this comment.
Suggested change
| if notification_already_exists?(item) && !@force_repost | |
| next | |
| end | |
| next if notification_already_exists?(item) && !@force_repost |
nofaralfasi
reviewed
Feb 22, 2024
Comment on lines
+77
to
79
| if legacy_dhcp_api? && (other.attrs[:hostname].present? && attrs[:hostname].present?) | ||
| to_compare << :hostname | ||
| end |
There was a problem hiding this comment.
Suggested change
| if legacy_dhcp_api? && (other.attrs[:hostname].present? && attrs[:hostname].present?) | |
| to_compare << :hostname | |
| end | |
| to_compare << :hostname if legacy_dhcp_api? && other.attrs[:hostname].present? && attrs[:hostname].present? |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed and optimized nested conditionals flagged by the Style/SoloNestedConditional cop.