Fixes #37215 - Stop reporting CV/LCE if not set to hosts #10074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Thanks @hao-yu!
This is correct because single_content_view and single_lifecycle_environment can return nil if the content facet doesn't have any content view environments.
ACK 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses safe navigation to allow reporting on hosts without content views or lifecycle environments (virt-who hypervisors).
Steps to Reproduce:
Additional info:
Similar issue to https://projects.theforeman.org/issues/37016
Safe navigation doesn't work for older safe mode, if we want to backport to older version, we need to create another PR which is similar to #10023