Fixes #37224 - Force Hosts to have a comment #10079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent the nil -> empty string transition we would either have to: - check the incoming changes and discard the unwanted ones - ignore these transitions when creating audits - just force hosts to always have a comment The last option felt like the least wrong one. This has an added benefit that searching for hosts without comment becomes somewhat easier.
ekohl
approved these changes
Mar 5, 2024
pondrejk
approved these changes
Mar 6, 2024
ofedoren
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent the nil -> empty string transition we would either have to:
The last option felt like the least wrong one. This has an added benefit that searching for hosts without comment becomes somewhat easier.